Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jacoblee23/edit program information #82

Merged
merged 28 commits into from
Apr 9, 2024
Merged

Feature/jacoblee23/edit program information #82

merged 28 commits into from
Apr 9, 2024
+975 −11

Conversation

mraysu
Copy link
Contributor

@mraysu mraysu commented Apr 9, 2024

Tracking Info

Resolves #30

Changes

Added buttons for creating and editing programs

  • Cancel dialog will keep admins from exiting on accident
  • Archive dialog allows admins to archive programs
    • Requires users to confirm by entering today's date before submitting

Testing

Edge testing, uploaded premade data using .json

Confirmation of Change

image
image
image
image
image
image
image

JacobLee23 and others added 25 commits January 30, 2024 23:19
@JacobLee23
feat: implement CSS for Figma design
bce6a98
@JacobLee23
feat: create src/api/programs.ts to handle program data
473c8e5
@JacobLee23
feat: create parseProgram() function to parse program JSON data
83e14ff
@JacobLee23
feat: create functions to handle program creation/updates
6532990
@JacobLee23
fix: correct ProgramForm.module.css path
587aa8a
@JacobLee23
feat: create frontend/src/components/ProgramForm.tsx
8c58809
@JacobLee23
feat: fill Promise.then() callback for createProgram()
da73ada
@JacobLee23
fix: rename CSS class names
e01e21d
@JacobLee23
Merge branch 'main' into feature/jacoblee23/edit-program-information
6987360
@JacobLee23
fix: update frontend/src/api/program.ts
1f00630
@JacobLee23
Merge branch 'main' of https://github.com/TritonSE/PIA-Program-Manager …
1715989 
…into feature/jacoblee23/edit-program-information
@JacobLee23
feat: update program.ts
76d2df0
@JacobLee23
feat: update ProgramForm.tsx
018899c
@JacobLee23
feat: create program add/edit form
3061139
@JacobLee23
feat: copy Figma Tailwind CSS
d8c4fbb
@JacobLee23
fix: update pages/index.tsx
dfd2c1d
@JacobLee23
feat: update components/ProgramFormButton.tsx
5914c7c
@mraysu
Updated UI
791c95f
@mraysu
Added form submission
066af61
@mraysu
Added V2 UI and default values
22abe5c
@mraysu
Merge with main
515c653
@mraysu
Fixed Radio Issue
ed89c87
@mraysu
Desktop Browser Archive
2a60778
@mraysu
Archive Mobile
739b1c1
@mraysu
Merge with main
dd045fa
@mraysu mraysu requested a review from adhi0331 as a code owner April 9, 2024 10:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6e94c2c):

https://pia-dev-60cea--pr82-feature-jacoblee23-e-tl1neyzi.web.app

(expires Tue, 16 Apr 2024 22:47:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

adhi0331
adhi0331 requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks really good! Left a few minor comments. If you could just fix the routing so that it matches the intended flow of the app that would be good. Also for the program page just add the add program button (no need to keep edit program since I can see that it works)

frontend/src/pages/index.tsx Outdated Show resolved Hide resolved
frontend/src/components/ProgramForm/types.ts Show resolved Hide resolved
frontend/src/pages/programs.tsx Outdated Show resolved Hide resolved
adhi0331
adhi0331 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adhi0331 adhi0331 requested a review from andrewzpu April 9, 2024 22:57
@adhi0331 adhi0331 merged commit da88393 into main Apr 9, 2024
4 checks passed
@adhi0331 adhi0331 deleted the feature/jacoblee23/edit-program-information branch April 9, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhi0331 adhi0331 adhi0331 approved these changes

@andrewzpu andrewzpu Awaiting requested review from andrewzpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit/Add Program Information] - Create UI
3 participants
@mraysu @adhi0331 @JacobLee23